Snape's role was complex, but insgesamt positive. Without him, Harry and Ron and Hermione wouldn't have had the sword needed to destroy the Horcruxes, and the students remaining in Hogwarts would have Lost the limited protection he could give him. And doubtless the Order would have been worse off without the information his spying provided.
